Skip to content

Comments

Config refactor#110

Open
dagelf wants to merge 11 commits intoTinyAGI:mainfrom
dagelf:config-refactor
Open

Config refactor#110
dagelf wants to merge 11 commits intoTinyAGI:mainfrom
dagelf:config-refactor

Conversation

@dagelf
Copy link

@dagelf dagelf commented Feb 16, 2026

  • New agent binary support can be added by just updating a configuration file
  • New channel drivers can be added without modifying core scripts
  • New example channel: TUI chat
  • New example model: qodercli

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 482e74fb31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +25 to +27
.replace(/\{\{message\}\}/g, ctx.message)
.replace(/\{\{model\}\}/g, ctx.model)
.replace(/\{\{cwd\}\}/g, ctx.cwd)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve literal template tokens in user prompts

The arg renderer substitutes {{message}} and then continues replacing {{model}}, {{cwd}}, and {{resume}} on the resulting string, so a user message that literally contains those tokens gets rewritten before it reaches the provider (for example, asking about {{model}} syntax will inject the actual model id). This corrupts prompt content and can change model behavior; placeholder expansion should not run over user-provided text.

Useful? React with 👍 / 👎.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally cant launch the command without it

Comment on lines +170 to +172
if [[ "$MODEL_CHOICE" =~ ^[sS]$ ]]; then
echo -e "${YELLOW}Using default model: ${MODEL_IDS[0]}${NC}"
MODEL="${MODEL_IDS[0]}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid deriving default model from sorted map keys

When users choose the skip/default path, the wizard sets MODEL to MODEL_IDS[0], but MODEL_IDS is built via jq ... keys[] (sorted lexicographically), not by intended preference order. With the current registry this can silently select unexpected defaults (e.g., Anthropic defaults to claude-opus-4-6, OpenAI to gpt-5.2), which changes cost/quality characteristics for newly configured agents.

Useful? React with 👍 / 👎.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevant, it shows a list its only if you skip

@dagelf
Copy link
Author

dagelf commented Feb 16, 2026

A local stt and tts pipeline would now be trivial to add as a channel, and from there turning it into voice notes on other channels would be equally trivial.

@jlia0
Copy link
Collaborator

jlia0 commented Feb 17, 2026

thanks for the amazing work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants